Mizah/mizzkey
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(client): prevent infinite resize loop (#9232)

Browse source 
* clientWidth?

* spacer?

* size directive?

* size directive

* use const
This commit is contained in:
tamaina 2022-12-26 12:55:10 +09:00 • committed by GitHub
parent 6acc10b4ba
commit f0fe930aae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 30 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
packages/client/src/directives/size.ts
View file

@ -8,6 +8,7 @@ const mountings = new Map<Element, {
resize: ResizeObserver;
intersection?: IntersectionObserver;
previousWidth: number;
twoPreviousWidth: number;
}>();
type ClassOrder = {
@ -66,7 +67,13 @@ function calc(el: Element) {
delete info.intersection;
}
mountings.set(el, Object.assign(info, { previousWidth: width }));
mountings.set(el, { ...info, ...{ previousWidth: width, twoPreviousWidth: info.previousWidth }});
// Prevent infinite resizing
// https://github.com/misskey-dev/misskey/issues/9076
if (info.twoPreviousWidth === width) {
return;
}
const cached = cache.get(getOrderName(width, info.value));
if (cached) {
@ -90,6 +97,7 @@ export default {
value: binding.value,
resize,
previousWidth: 0,
twoPreviousWidth: 0,
});
calc(src);