Mizah/mizzkey
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(users/show): ユーザーが見つからなかった場合に404ステータスコードを返す (#10344)

Browse source 
* fix(users/show): ユーザーが見つからなかった場合に404ステータスコードを返す

* test(users/show): ステータスコードの期待値を修正
This commit is contained in:
choco 2023-03-20 14:26:11 +09:00 committed by GitHub
parent 3014e3e5f8
commit eb5781465b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/backend/src/server/api/endpoints/users/show.ts
View file

@ -48,6 +48,7 @@ export const meta = {
message: 'No such user.', message: 'No such user.',
code: 'NO_SUCH_USER', code: 'NO_SUCH_USER',
id: '4362f8dc-731f-4ad8-a694-be5a88922a24', id: '4362f8dc-731f-4ad8-a694-be5a88922a24',
httpStatusCode: 404,
}, },
}, },
} as const; } as const;

4
packages/backend/test/e2e/endpoints.ts
View file

@ -162,14 +162,14 @@ describe('Endpoints', () => {
const res = await api('/users/show', { const res = await api('/users/show', {
userId: '000000000000000000000000', userId: '000000000000000000000000',
}); });
assert.strictEqual(res.status, 400); assert.strictEqual(res.status, 404);
}); });
test('間違ったIDで怒られる', async () => { test('間違ったIDで怒られる', async () => {
const res = await api('/users/show', { const res = await api('/users/show', {
userId: 'kyoppie', userId: 'kyoppie',
}); });
assert.strictEqual(res.status, 400); assert.strictEqual(res.status, 404);
}); });
}); });