From 3ab2a008f2c65ad7314168b6b6700753bbe997a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Acid=20Chicken=20=28=E7=A1=AB=E9=85=B8=E9=B6=8F=29?=
<root@acid-chicken.com>
Date: Mon, 3 Apr 2023 03:03:43 +0900
Subject: [PATCH] ci(#10336): change parameters
---
.../src/components/global/MkAvatar.stories.impl.ts | 1 +
.../src/components/global/MkPageHeader.stories.impl.ts | 4 ++++
.../frontend/src/components/global/MkPageHeader.tabs.vue | 7 +------
packages/frontend/src/components/global/MkPageHeader.vue | 3 +--
4 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/packages/frontend/src/components/global/MkAvatar.stories.impl.ts b/packages/frontend/src/components/global/MkAvatar.stories.impl.ts
index 6153f81294..6c46f75b5f 100644
--- a/packages/frontend/src/components/global/MkAvatar.stories.impl.ts
+++ b/packages/frontend/src/components/global/MkAvatar.stories.impl.ts
@@ -54,6 +54,7 @@ export const ProfilePageCat = {
},
},
parameters: {
+ ...ProfilePage.parameters,
chromatic: {
/* Your story couldn’t be captured because it exceeds our 25,000,000px limit. Its dimensions are 5,504,893x5,504,892px. Possible ways to resolve:
* * Separate pages into components
diff --git a/packages/frontend/src/components/global/MkPageHeader.stories.impl.ts b/packages/frontend/src/components/global/MkPageHeader.stories.impl.ts
index f164e0957d..5519d60fc4 100644
--- a/packages/frontend/src/components/global/MkPageHeader.stories.impl.ts
+++ b/packages/frontend/src/components/global/MkPageHeader.stories.impl.ts
@@ -28,6 +28,10 @@ export const Empty = {
},
parameters: {
layout: 'centered',
+ chromatic: {
+ /* This component has animations that are implemented with JavaScript. So it's unstable to take a snapshot. */
+ disableSnapshot: true,
+ },
},
} satisfies StoryObj<typeof MkPageHeader>;
export const OneTab = {
diff --git a/packages/frontend/src/components/global/MkPageHeader.tabs.vue b/packages/frontend/src/components/global/MkPageHeader.tabs.vue
index 166f632c6f..9e1da64e61 100644
--- a/packages/frontend/src/components/global/MkPageHeader.tabs.vue
+++ b/packages/frontend/src/components/global/MkPageHeader.tabs.vue
@@ -52,7 +52,6 @@ import { onMounted, onUnmounted, watch, nextTick, shallowRef } from 'vue';
import { defaultStore } from '@/store';
const props = withDefaults(defineProps<{
- static?: boolean;
tabs?: Tab[];
tab?: string;
rootEl?: HTMLElement;
@@ -128,11 +127,7 @@ async function enter(el: HTMLElement) {
entering = false;
});
- if (props.static) {
- renderTab();
- } else {
- setTimeout(renderTab, 170);
- }
+ setTimeout(renderTab, 170);
}
function afterEnter(el: HTMLElement) {
//el.style.width = '';
diff --git a/packages/frontend/src/components/global/MkPageHeader.vue b/packages/frontend/src/components/global/MkPageHeader.vue
index 94e1e8dd0b..0d229a9370 100644
--- a/packages/frontend/src/components/global/MkPageHeader.vue
+++ b/packages/frontend/src/components/global/MkPageHeader.vue
@@ -19,7 +19,7 @@
</div>
</div>
</div>
- <XTabs v-if="!narrow || hideTitle" :class="$style.tabs" :static="static" :tab="tab" :tabs="tabs" :root-el="el" @update:tab="key => emit('update:tab', key)" @tab-click="onTabClick"/>
+ <XTabs v-if="!narrow || hideTitle" :class="$style.tabs" :tab="tab" :tabs="tabs" :root-el="el" @update:tab="key => emit('update:tab', key)" @tab-click="onTabClick"/>
</template>
<div v-if="(!thin_ && narrow && !hideTitle) || (actions && actions.length > 0)" :class="$style.buttonsRight">
<template v-for="action in actions">
@@ -43,7 +43,6 @@ import { injectPageMetadata } from '@/scripts/page-metadata';
import { $i, openAccountMenu as openAccountMenu_ } from '@/account';
const props = withDefaults(defineProps<{
- static?: boolean;
tabs?: Tab[];
tab?: string;
actions?: {