perf: omit search for immutable static requests (#13265)

* perf: omit search for immutable static requests

* perf: also applies to /files

* fix: exclude /proxy

* /files/:key/*を301 redirectに

---------

Co-authored-by: tamaina <tamaina@hotmail.co.jp>

packages/backend/src/misc/fastify-hook-handlers.ts

@@ -0,0 +1,9 @@
+import type { onRequestHookHandler } from 'fastify';
+
+export const handleRequestRedirectToOmitSearch: onRequestHookHandler = (request, reply, done) => {
+	const index = request.url.indexOf('?');
+	if (~index) {
+		reply.redirect(301, request.url.slice(0, index));
+	}
+	done();
+};

packages/backend/src/server/FileServerService.ts

@@ -27,6 +27,7 @@ import { LoggerService } from '@/core/LoggerService.js';
 import { bindThis } from '@/decorators.js';
 import { isMimeImage } from '@/misc/is-mime-image.js';
 import { correctFilename } from '@/misc/correct-filename.js';
+import { handleRequestRedirectToOmitSearch } from '@/misc/fastify-hook-handlers.js';
 import type { FastifyInstance, FastifyRequest, FastifyReply, FastifyPluginOptions } from 'fastify';
 
 const _filename = fileURLToPath(import.meta.url);
@@ -67,6 +68,8 @@ export class FileServerService {
 			done();
 		});
 
+		fastify.register((fastify, options, done) => {
+			fastify.addHook('onRequest', handleRequestRedirectToOmitSearch);
 			fastify.get('/files/app-default.jpg', (request, reply) => {
 				const file = fs.createReadStream(`${_dirname}/assets/dummy.png`);
 				reply.header('Content-Type', 'image/jpeg');
@@ -79,8 +82,9 @@ export class FileServerService {
 					.catch(err => this.errorHandler(request, reply, err));
 			});
 			fastify.get<{ Params: { key: string; } }>('/files/:key/*', async (request, reply) => {
-			return await this.sendDriveFile(request, reply)
+				return await reply.redirect(301, `${this.config.url}/files/${request.params.key}`);
-				.catch(err => this.errorHandler(request, reply, err));
+			});
+			done();
 		});
 
 		fastify.get<{

packages/backend/src/server/web/ClientServerService.ts

@@ -34,6 +34,7 @@ import { ChannelEntityService } from '@/core/entities/ChannelEntityService.js';
 import type { ChannelsRepository, ClipsRepository, FlashsRepository, GalleryPostsRepository, MiMeta, NotesRepository, PagesRepository, ReversiGamesRepository, UserProfilesRepository, UsersRepository } from '@/models/_.js';
 import type Logger from '@/logger.js';
 import { deepClone } from '@/misc/clone.js';
+import { handleRequestRedirectToOmitSearch } from '@/misc/fastify-hook-handlers.js';
 import { bindThis } from '@/decorators.js';
 import { FlashEntityService } from '@/core/entities/FlashEntityService.js';
 import { RoleService } from '@/core/RoleService.js';
@@ -253,12 +254,17 @@ export class ClientServerService {
 
 		//#region vite assets
 		if (this.config.clientManifestExists) {
+			fastify.register((fastify, options, done) => {
 				fastify.register(fastifyStatic, {
 					root: viteOut,
 					prefix: '/vite/',
 					maxAge: ms('30 days'),
+					immutable: true,
 					decorateReply: false,
 				});
+				fastify.addHook('onRequest', handleRequestRedirectToOmitSearch);
+				done();
+			});
 		} else {
 			const port = (process.env.VITE_PORT ?? '5173');
 			fastify.register(fastifyProxy, {
@@ -292,12 +298,17 @@ export class ClientServerService {
 			decorateReply: false,
 		});
 
+		fastify.register((fastify, options, done) => {
 			fastify.register(fastifyStatic, {
 				root: tarball,
 				prefix: '/tarball/',
+				maxAge: ms('30 days'),
 				immutable: true,
 				decorateReply: false,
 			});
+			fastify.addHook('onRequest', handleRequestRedirectToOmitSearch);
+			done();
+		});
 
 		fastify.get('/favicon.ico', async (request, reply) => {
 			return reply.sendFile('/favicon.ico', staticAssets);