From 26198a15b7b0bd47dbd2157fe11c0343cda1cfee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E3=81=BE=E3=81=A3=E3=81=A1=E3=82=83=E3=81=A8=E3=83=BC?=
 =?UTF-8?q?=E3=81=AB=E3=82=85?=
 <17376330+u1-liquid@users.noreply.github.com>
Date: Wed, 27 Dec 2023 08:37:57 +0900
Subject: [PATCH] fix code quality issues

---
 packages/frontend/src/components/MkCode.vue   |  4 +---
 .../frontend/src/components/MkMediaList.vue   |  2 +-
 .../frontend/src/components/MkPostForm.vue    | 22 ++++++++++++++-----
 packages/frontend/src/types/menu.ts           |  2 +-
 packages/frontend/src/types/page-header.ts    |  2 +-
 5 files changed, 20 insertions(+), 12 deletions(-)

diff --git a/packages/frontend/src/components/MkCode.vue b/packages/frontend/src/components/MkCode.vue
index 2c016e4d7c..137d4c2bd4 100644
--- a/packages/frontend/src/components/MkCode.vue
+++ b/packages/frontend/src/components/MkCode.vue
@@ -66,11 +66,9 @@ const XCode = defineAsyncComponent(() => import('@/components/MkCode.core.vue'))
 .codePlaceholderRoot {
 	display: block;
 	width: 100%;
-	background: none;
 	border: none;
 	outline: none;
-  font: inherit;
-  color: inherit;
+	font: inherit;
 	cursor: pointer;
 
 	box-sizing: border-box;
diff --git a/packages/frontend/src/components/MkMediaList.vue b/packages/frontend/src/components/MkMediaList.vue
index c5be2a2f62..5dce5775ae 100644
--- a/packages/frontend/src/components/MkMediaList.vue
+++ b/packages/frontend/src/components/MkMediaList.vue
@@ -74,7 +74,7 @@ async function calcAspectRatio() {
 			gallery.value.style.aspectRatio = ratioMax(16 / 9);
 			break;
 		case '1_1':
-			gallery.value.style.aspectRatio = ratioMax(1 / 1);
+			gallery.value.style.aspectRatio = ratioMax(1);
 			break;
 		case '2_3':
 			gallery.value.style.aspectRatio = ratioMax(2 / 3);
diff --git a/packages/frontend/src/components/MkPostForm.vue b/packages/frontend/src/components/MkPostForm.vue
index 89b769470a..cf41e0c1cd 100644
--- a/packages/frontend/src/components/MkPostForm.vue
+++ b/packages/frontend/src/components/MkPostForm.vue
@@ -100,7 +100,7 @@ SPDX-License-Identifier: AGPL-3.0-only
 </template>
 
 <script lang="ts" setup>
-import { inject, watch, nextTick, onMounted, defineAsyncComponent, provide, shallowRef, ref, computed } from 'vue';
+import { inject, watch, nextTick, onMounted, onUnmounted, defineAsyncComponent, provide, shallowRef, ref, computed } from 'vue';
 import * as mfm from 'mfm-js';
 import * as Misskey from 'misskey-js';
 import insertTextAtCursor from 'insert-text-at-cursor';
@@ -191,7 +191,9 @@ if (props.initialVisibleUsers) {
 	props.initialVisibleUsers.forEach(pushVisibleUser);
 }
 const reactionAcceptance = ref(defaultStore.state.reactionAcceptance);
-const autocomplete = ref(null);
+const autocompleteTextareaInput = ref<Autocomplete | null>(null);
+const autocompleteCwInput = ref<Autocomplete | null>(null);
+const autocompleteHashtagsInput = ref<Autocomplete | null>(null);
 const draghover = ref(false);
 const quoteId = ref(null);
 const hasNotSpecifiedMentions = ref(false);
@@ -909,10 +911,9 @@ onMounted(() => {
 		});
 	}
 
-	// TODO: detach when unmount
-	new Autocomplete(textareaEl.value, text);
-	new Autocomplete(cwInputEl.value, cw);
-	new Autocomplete(hashtagsInputEl.value, hashtags);
+	autocompleteTextareaInput.value = new Autocomplete(textareaEl.value, text);
+	autocompleteCwInput.value = new Autocomplete(cwInputEl.value, cw);
+	autocompleteHashtagsInput.value = new Autocomplete(hashtagsInputEl.value, hashtags);
 
 	nextTick(() => {
 		// 書きかけの投稿を復元
@@ -955,6 +956,15 @@ onMounted(() => {
 	});
 });
 
+onUnmounted(() => {
+	autocompleteTextareaInput.value?.detach();
+	autocompleteTextareaInput.value = null;
+	autocompleteCwInput.value?.detach();
+	autocompleteCwInput.value = null;
+	autocompleteHashtagsInput.value?.detach();
+	autocompleteHashtagsInput.value = null;
+});
+
 defineExpose({
 	clear,
 });
diff --git a/packages/frontend/src/types/menu.ts b/packages/frontend/src/types/menu.ts
index f4516bbe5b..aead404574 100644
--- a/packages/frontend/src/types/menu.ts
+++ b/packages/frontend/src/types/menu.ts
@@ -6,7 +6,7 @@
 import * as Misskey from 'misskey-js';
 import { Ref } from 'vue';
 
-export type MenuAction = (ev: MouseEvent) => void;
+export type MenuAction = (ev: MouseEvent) => Promise<void> | void;
 
 export type MenuDivider = { type: 'divider' };
 export type MenuNull = undefined;
diff --git a/packages/frontend/src/types/page-header.ts b/packages/frontend/src/types/page-header.ts
index 295b97a7fd..7f3838c543 100644
--- a/packages/frontend/src/types/page-header.ts
+++ b/packages/frontend/src/types/page-header.ts
@@ -7,5 +7,5 @@ export type PageHeaderItem = {
     text: string;
     icon: string;
     highlighted?: boolean;
-    handler: (ev: MouseEvent) => void;
+    handler: (ev: MouseEvent) => Promise<void> | void;
 };